Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add '.any' modifier to a few search attributes #2229

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Conversation

chazlarson
Copy link
Contributor

@chazlarson chazlarson commented Sep 19, 2024

Description

The ".any" modifier for a few search attributes was not included in the "is this valid?" list.

Seems to be implemented downstream, just not accepted as valid.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Please delete options that are not relevant.

  • Updated the CHANGELOG with the changes

@chazlarson
Copy link
Contributor Author

Before this change:

|====================================================================================================|
|                          Dinosaur Action Collection in Kometa-Demo-Movies                          |
|====================================================================================================|
|                                                                                                    |
|============================== Validating Dinosaur Action Attributes ===============================|
|                                                                                                    |
| Looking for: Dinosaur Action                                                                       |
|                                                                                                    |
| Validating Method: sort_title                                                                      |
| Value: !!!0                                                                                        |
|                                                                                                    |
| Validating Method: imdb_search                                                                     |
| Value: {'limit': 50, 'plot.any': 'dinosaur, pre-historic, reptile'}                                |
| Traceback (most recent call last):                                                                 |
|   File "/home/chaz/HIDDEN-STUFF/kometa.py", line 784, in run_collection                            |
|     builder = CollectionBuilder(config, metadata, mapping_name, collection_attrs, library=library, extra=output_str) |
|               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ |
|   File "/home/chaz/HIDDEN-STUFF/modules/builder.py", line 1041, in __init__                        |
|     self._imdb(method_name, method_data)                                                           |
|   File "/home/chaz/HIDDEN-STUFF/modules/builder.py", line 1563, in _imdb                           |
|     raise Failed(f"{self.Type} Error: {method_name} {search_method} attribute not supported")      |
| modules.util.Failed: Collection Error: imdb_search plot.any attribute not supported                |
|                                                                                                    |
| Collection Error: imdb_search plot.any attribute not supported                                     |
|                                                                                                    |
|====================================================================================================|
|                                Finished Dinosaur Action Collection                                 |
|                                    Collection Run Time: 0:00:00                                    |
|====================================================================================================|

With this change:

|====================================================================================================|
|                          Dinosaur Action Collection in Kometa-Demo-Movies                          |
|====================================================================================================|
|                                                                                                    |
|============================== Validating Dinosaur Action Attributes ===============================|
|                                                                                                    |
| Looking for: Dinosaur Action                                                                       |
|                                                                                                    |
| Validating Method: sort_title                                                                      |
| Value: !!!0                                                                                        |
|                                                                                                    |
| Validating Method: imdb_search                                                                     |
| Value: {'limit': 50, 'plot.any': 'dinosaur, pre-historic, reptile'}                                |
|                                                                                                    |
| Validation Successful                                                                              |
|                                                                                                    |
|================================ Running Dinosaur Action Collection ================================|
|                                                                                                    |
| Sync Mode: append                                                                                  |
|                                                                                                    |
| Builder: imdb_search: {'limit': 50, 'plot.any': ['dinosaur', 'pre-historic', 'reptile']}           |
|                                                                                                    |
| Processing IMDb Search:                                                                            |
|     limit: 50                                                                                      |
|     plot.any: ['dinosaur', 'pre-historic', 'reptile']                                              |
|                                                                                                    |
| 50 IDs Found                                                                                       |
|                                                                                                    |
|                                                                                                    |
|=============================== Adding to Dinosaur Action Collection ===============================|
|                                                                                                    |
|  1/11 | Dinosaur Action Collection | + | Jurassic Park (1993)                                      |
|  2/11 | Dinosaur Action Collection | + | Jurassic World Dominion (2022)                            |
|  3/11 | Dinosaur Action Collection | + | Jurassic World (2015)                                     |
|  4/11 | Dinosaur Action Collection | + | Minions (2015)                                            |
|  5/11 | Dinosaur Action Collection | + | Jurassic World: Fallen Kingdom (2018)                     |
|  6/11 | Dinosaur Action Collection | + | Ice Age: Collision Course (2016)                          |
|  7/11 | Dinosaur Action Collection | + | The Land Before Time (1988)                               |
|  8/11 | Dinosaur Action Collection | + | Meet the Robinsons (2007)                                 |
|  9/11 | Dinosaur Action Collection | + | Ice Age: Dawn of the Dinosaurs (2009)                     |
| 10/11 | Dinosaur Action Collection | + | Piranha 3DD (2012)                                        |
| 11/11 | Dinosaur Action Collection | + | The Good Dinosaur (2015)                                  |
|                                                                                                    |
| 11 Movies Processed 11 Movies Added                                                                |
|                                                                                                    |
|========================= Updating Metadata of Dinosaur Action Collection ==========================|
|                                                                                                    |
| Collection Metadata Edits                                                                          |
| Sort Title | !!!0                                                                                  |
| Label | +Kometa                                                                                    |
| Metadata: Update Completed                                                                         |
|                                                                                                    |
|                                                                                                    |
|====================================================================================================|
|                                Finished Dinosaur Action Collection                                 |
|                                    Collection Run Time: 0:00:05                                    |
|====================================================================================================|

@meisnate12 meisnate12 merged commit 17a44f6 into nightly Sep 20, 2024
4 checks passed
@meisnate12 meisnate12 deleted the bugfix/2228 branch September 20, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants