Custom system/preset mode mapping for TRV602Z #8655
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Koenkk I think I've got the converter working. The key was adding a null-name datapoint, a few other thermostats do it for some reason. Does that make sense to you? |
|
That's fine but can we reduce code duplication by merging it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value converter
thermostatSystemModeAndPresetis not suitable for this valve. Currently system mode "heat" changes preset mode to "comfort" while system mode "off" changes preset mode to "eco".Please do not merge this PR yet. For some reason with these changes the valve will not respond to changing system or preset modes at all. I have zero past experience with this so I hope @Koenkk or @SteveOswald (as you made changes to this valve's support recently) can see where I made a mistake. At the moment I'm out of ideas. Nothing in the Z2M logs even with the debug level.