Add White Label Girier JR-ZPM03 Smart Plug (_TZ3000_okaz9tjs) to TS011F_plug_3
#8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Jan 5, 2025
| @@ -5593,6 +5593,7 @@ const definitions: DefinitionWithExtend[] = [ | |||
| {vendor: 'AVATTO', model: 'MIUCOT10Z'}, | |||
| {vendor: 'Neo', model: 'NAS-WR01B'}, | |||
| {vendor: 'Neo', model: 'PLUG-001SPB2'}, | |||
| {vendor: 'Girier', model: 'JR-ZPM03', fingerprint: [{manufacturerName: '_TZ3000_okaz9tjs', manufacturerID: 4660}]}, | |||
There was a problem hiding this comment.
Please use tuya.whitelabel() like below.
There was a problem hiding this comment.
will this code work? because it shares the same manufacturerName as Tuya BSD29_1.
tuya.whitelabel('Girier', 'JR-ZPM03', 'Smart plug (with power monitoring by polling)', ['_TZ3000_okaz9tjs']),
tuya.whitelabel('Tuya', 'BSD29_1', 'Smart plug (with power monitoring by polling)', ['_TZ3000_okaz9tjs']),if so, I'll commit the change.
There was a problem hiding this comment.
No because the manufacturer name is exactly the same (_TZ3000_okaz9tjs)
There was a problem hiding this comment.
any suggestion to differentiate 2 devices that share the same manufacturerName? maybe from manufacturerID?
maybe by passing fingerprint to whitelabel function (might need to update the whitelabel function.
There was a problem hiding this comment.
the manufacturer ID will also be the same, I don't think there is a way to distinguish them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds whitelabel
GiriermodelJR-ZPM03(manufacturer name_TZ3000_okaz9tjs) to the existingTS011F_plug_3.In my case, it's incorrectly shown as Tuya
BSD29_1, I put the white label toTS011F_plug_3and added themanufacturerIDto the fingerprint to differentiate with the existing.It addresses the issue reported here Koenkk/zigbee2mqtt#24721
Zigbee2MQTT Dashboard
Product Image
Product Link
AliExpress
Device Info JSON
{ "id": 15, "type": "Router", "ieeeAddr": "0x70b3d52b60124c70", "nwkAddr": 3636, "manufId": 4660, "manufName": "_TZ3000_okaz9tjs", "powerSource": "Mains (single phase)", "modelId": "TS011F", "epList": [ 1 ], "endpoints": { "1": { "profId": 260, "epId": 1, "devId": 81, "inClusterList": [ 0, 6, 3, 4, 5, 57345, 2820, 1794 ], "outClusterList": [ 25 ], "clusters": { "genBasic": { "attributes": { "modelId": "TS011F", "manufacturerName": "_TZ3000_okaz9tjs", "powerSource": 1, "zclVersion": 2, "appVersion": 100, "stackVersion": 1, "hwVersion": 2, "dateCode": "20210625", "swBuildId": "500+TZSKT31BS102" } }, "haElectricalMeasurement": { "attributes": { "acCurrentDivisor": 1000, "acCurrentMultiplier": 1, "rmsVoltage": 231, "rmsCurrent": 587, "activePower": 82 } }, "seMetering": { "attributes": { "divisor": 100, "multiplier": 1, "currentSummDelivered": 229 } }, "genOnOff": { "attributes": { "onOff": 1 } }, "manuSpecificTuya_3": { "attributes": { "powerOnBehavior": 2 } } }, "binds": [], "configuredReportings": [], "meta": {} } }, "appVersion": 4660, "stackVersion": 1, "hwVersion": 2, "dateCode": "20210625", "swBuildId": "500+TZSKT31BS102", "zclVersion": 2, "interviewCompleted": true, "meta": { "configured": 332242049 }, "lastSeen": 1735989812717 }