Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GL-C-008 #8375

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add GL-C-008 #8375

wants to merge 1 commit into from

Conversation

Aogu181
Copy link
Contributor

@Aogu181 Aogu181 commented Nov 25, 2024

| ----------- | ------------------------------------------ |
| Model | GL-C-008 |
| Vendor | Gledopto |

Description Zigbee LED Controller RGB+CCT

@Koenkk
Copy link
Owner

Koenkk commented Nov 25, 2024

This device is already supported:

zigbeeModel: ['GL-C-008'],

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 26, 2024

image
model is GL-C-008-1ID , not GL-C-008

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 26, 2024

But I'm showing it's not available
image

@Koenkk
Copy link
Owner

Koenkk commented Nov 27, 2024

Because the Zigbee model on the UI is empty, it looks that interview failed, can you try to force remove the device and re-pair again?

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 27, 2024

Because the Zigbee model on the UI is empty, it looks that interview failed, can you try to force remove the device and re-pair again?

I reset and tried again, but it still doesn't display correctly.
I think the model number he sent to z2m is GL-C-008, not GL-C-008-1ID or GL-C-008-2ID.

@Koenkk
Copy link
Owner

Koenkk commented Nov 27, 2024

The match is done based on the zigbeeModel or fingerprint, the model is just a cosmetic thing. Did the interview succeed now? You can also press the "i" button to trigger a re-interview.

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 27, 2024

The match is done based on the zigbeeModel or fingerprint, the model is just a cosmetic thing. Did the interview succeed now? You can also press the "i" button to trigger a re-interview.

Still no use.
image

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 27, 2024

image

@pjxturner
Copy link
Contributor

Just FYI. I pulled an old GL-C-008 out of my archive, and it paired right away. Exactly the same controller pictured at Koenkk/zigbee2mqtt#24914 (comment).
241127 GL-C-008 pairing
The Dev console shows it as:

const {deviceEndpoints, light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['GL-C-008'],
    model: 'GL-C-008',
    vendor: 'GLEDOPTO',
    description: 'Automatically generated definition',
    extend: [deviceEndpoints({"endpoints":{"11":11,"13":13}}), light({"colorTemp":{"range":[150,500]},"color":{"modes":["xy","hs"],"enhancedHue":true}})],
    meta: {"multiEndpoint":true},
};

module.exports = definition;

So it's working for me, even though it does pickup the Description of Zigbee LED Controller RGB+CCT (1 ID) from src/devices/gledopto.ts which probably should be listed as a whiteLabel version of the GL-C-008 model (as distinct from the modelId: GL-C-008-1ID), but I've read though all the history of the confusion between the modelId and model names for the RGBCCT and other Gledopto controllers - Plus, Pro, Pro+, 1ID, 2ID (multi-endpoints), MIX, Multi-mode etc., so this is understandable.

I'm glad Gledopto's getting more involved directly with Z2M. As a user of many Gledopto products, It'd be nice to clean up src/devices/gledopto.ts so it's more accurate and complete now and going forward. Let me know if I can help.
(I'm currently working on a PR to update the whiteLabel info of all the Multi-mode controllers, including the GL-C-204P announced yesterday).

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 27, 2024

Just FYI. I pulled an old GL-C-008 out of my archive, and it paired right away. Exactly the same controller pictured at Koenkk/zigbee2mqtt#24914 (comment). 241127 GL-C-008 pairing The Dev console shows it as:

const {deviceEndpoints, light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['GL-C-008'],
    model: 'GL-C-008',
    vendor: 'GLEDOPTO',
    description: 'Automatically generated definition',
    extend: [deviceEndpoints({"endpoints":{"11":11,"13":13}}), light({"colorTemp":{"range":[150,500]},"color":{"modes":["xy","hs"],"enhancedHue":true}})],
    meta: {"multiEndpoint":true},
};

module.exports = definition;

So it's working for me, even though it does pickup the Description of Zigbee LED Controller RGB+CCT (1 ID) from src/devices/gledopto.ts which probably should be listed as a whiteLabel version of the GL-C-008 model (as distinct from the modelId: GL-C-008-1ID), but I've read though all the history of the confusion between the modelId and model names for the RGBCCT and other Gledopto controllers - Plus, Pro, Pro+, 1ID, 2ID (multi-endpoints), MIX, Multi-mode etc., so this is understandable.

I'm glad Gledopto's getting more involved directly with Z2M. As a user of many Gledopto products, It'd be nice to clean up src/devices/gledopto.ts so it's more accurate and complete now and going forward. Let me know if I can help. (I'm currently working on a PR to update the whiteLabel info of all the Multi-mode controllers, including the GL-C-204P announced yesterday).

Thank you for choosing and using Gledopto's products. We have only recently started handling customer complaints about Zigbee 2MQTT (z2m), so there is still much room for learning and improvement in this field. Due to recent customer feedback that GL-C-008 is not supported on z2m, we tested a product and found that z2m cannot display GL-C-008 information correctly. Therefore, I would like to ask if you have added any configurations?

@Koenkk
Copy link
Owner

Koenkk commented Nov 27, 2024

could you restart z2m, interview the device and provide the full debug lpg of this?

See this on how to enable debug logging.

@pjxturner
Copy link
Contributor

P.S. My pairing was of a newly reset GL-C-008 that I hadn't used before, with no local file or settings modifications in Home Assistant or Zigbee2MQTT.

@Aogu181
Copy link
Contributor Author

Aogu181 commented Nov 27, 2024

could you restart z2m, interview the device and provide the full debug lpg of this?

See this on how to enable debug logging.

7eca76cc_zigbee2mqtt_2024-11-27T09-15-02.516Z.log

@mosanwen
Copy link
Contributor

Just FYI. I pulled an old GL-C-008 out of my archive, and it paired right away. Exactly the same controller pictured at Koenkk/zigbee2mqtt#24914 (comment). 241127 GL-C-008 pairing The Dev console shows it as:

const {deviceEndpoints, light} = require('zigbee-herdsman-converters/lib/modernExtend');

const definition = {
    zigbeeModel: ['GL-C-008'],
    model: 'GL-C-008',
    vendor: 'GLEDOPTO',
    description: 'Automatically generated definition',
    extend: [deviceEndpoints({"endpoints":{"11":11,"13":13}}), light({"colorTemp":{"range":[150,500]},"color":{"modes":["xy","hs"],"enhancedHue":true}})],
    meta: {"multiEndpoint":true},
};

module.exports = definition;

So it's working for me, even though it does pickup the Description of Zigbee LED Controller RGB+CCT (1 ID) from src/devices/gledopto.ts which probably should be listed as a whiteLabel version of the GL-C-008 model (as distinct from the modelId: GL-C-008-1ID), but I've read though all the history of the confusion between the modelId and model names for the RGBCCT and other Gledopto controllers - Plus, Pro, Pro+, 1ID, 2ID (multi-endpoints), MIX, Multi-mode etc., so this is understandable.

I'm glad Gledopto's getting more involved directly with Z2M. As a user of many Gledopto products, It'd be nice to clean up src/devices/gledopto.ts so it's more accurate and complete now and going forward. Let me know if I can help. (I'm currently working on a PR to update the whiteLabel info of all the Multi-mode controllers, including the GL-C-204P announced yesterday).

Thanks very much for your working on GLEDOPT products,I am the software engineer from GLEDOPTO. I can explain GL-C-204P.
Compared to the GL-C-201P, only the voltage and current are different, the function is the same. both of them are 5in1 controller,"GL-C-204P "and "GL-C-201P"are just a product name ,not a modelID and something else about zigbee protocol. We have a buttom on the controller to switch mode: RGBCCT,RGBW ,RGB,CCT,DIMMER. when it switch to RGBCCT mode, The controller is a EXTENDED COLOR LIGHT(0x010D), the modelID is "GL-C-008P";when it switch to RGBW mode, The controller is also a EXTENDED COLOR LIGHT(0x010D), the modelID is "GL-C-007P";when it switch to RGB mode, The controller is a COLOR DIMMEABLE LIGHT(0x0102), the modelID is "GL-C-003P";when it switch to CCT mode, The controller is a COLOR TEMPERATURE LIGHT(0x010C), the modelID is "GL-C-006P";when it switch to DIMMER mode, The controller is a DIMMEABLE LIGHT(0x0101), the modelID is "GL-C-009P"; that's all .hope it is clear, Let me know if you have any questions.

@pjxturner
Copy link
Contributor

Thanks @mosanwen. That makes perfect sense to me. It's just another line on the table ( Koenkk/zigbee2mqtt.io#3219 (comment)) I created when I added the Multi-mode controller information to the documents.

I own and use a number of these devices which is I why got involved and tried to help explain why the Model: GL-C-003P (CCT modelId:GL-C-006P & DIM modelId:GL-C-009P) is different to and doesn't report the modelId:GL-C-003P (RGB) - Koenkk/zigbee2mqtt#24091. Once again, a terrible naming decision in the first place, but at least that's all been fixed.

I've updated the documentation notes for the 5 different modelId's. I just haven't submitted the PR yet, as I'm trying to make the language I used clearer and more easily understood.

@Koenkk
Copy link
Owner

Koenkk commented Nov 27, 2024

@Aogu181 it looks like the Gledopto device does not respond to requests from the coordinator, it fails to read the modelId for example:

zh:controller:device: Interview - first modelID retrieval attempt failed, retrying after 10 seconds...

When this fails, no matter what definition your put in zigbee-herdsman-converters, it will never be detected since it's simply missing the modelId. I'm not sure why it's failing in your case, I noticed you are using the legacy ezsp driver, the new ember driver might help:
You are using the old ezsp driver, it's recommended to use the new ember drivers (info)

@mosanwen
Copy link
Contributor

Thanks @mosanwen. That makes perfect sense to me. It's just another line on the table ( Koenkk/zigbee2mqtt.io#3219 (comment)) I created when I added the Multi-mode controller information to the documents.

I own and use a number of these devices which is I why got involved and tried to help explain why the Model: GL-C-003P (CCT modelId:GL-C-006P & DIM modelId:GL-C-009P) is different to and doesn't report the modelId:GL-C-003P (RGB) - Koenkk/zigbee2mqtt#24091. Once again, a terrible naming decision in the first place, but at least that's all been fixed.

I've updated the documentation notes for the 5 different modelId's. I just haven't submitted the PR yet, as I'm trying to make the language I used clearer and more easily understood.

Thank you again, about this naming rule, here is a historical reason, we made zigbee products, some gateways have a whitelisting, only whitelisted products, can enter this gateway smoothly, so when we made 5in1 products, in order to be able to enter such as this gateway smoothly, the different modes were applied to the previous model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants