-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recognition improvement for Lonsonho X701A #8156
Conversation
adding led indicator option
Recognition improvement for Lonsonho X702A
src/devices/tuya.ts
Outdated
@@ -3653,6 +3653,20 @@ const definitions: DefinitionWithExtend[] = [ | |||
await reporting.bind(device.getEndpoint(1), coordinatorEndpoint, ['genOnOff']); | |||
}, | |||
}, | |||
{ | |||
zigbeeModel: ['TS0001'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zigbeeModel: ['TS0001'], | |
fingerprint: tuya.fingerprint('TS0001', ['_TZ3000_t3s9qmmg']), |
src/devices/tuya.ts
Outdated
description: '1 gang switch with backlight', | ||
extend: [tuya.modernExtend.tuyaOnOff({indicatorMode: true})], | ||
whiteLabel: [ | ||
tuya.whitelabel('Lonsonho', 'X701A', '1 gang switch with backlight', ['_TZ3000_t3s9qmmg']), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be removed
src/devices/tuya.ts
Outdated
{ | ||
zigbeeModel: ['TS0001'], | ||
model: 'X701A', | ||
vendor: 'Lonsonho', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please modify lonsonho.ts
instead of tuya.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, moved to lonsonho.ts
.
Thanks! Could you also submit a picture for the docs? This can be done by:
Make sure that:
|
Thanks! |
Done: Koenkk/zigbee2mqtt.io#3281 Thanks for help with PR changes :) |
Hello
I added custom converter to add the option of LED indicator. Everything works fine the same as the X702A version (similar to #6117 )
It is looks the same as https://www.zigbee2mqtt.io/devices/X711A.html