Allow for using UniFi OS based devices #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this works for a Dream Machine Pro. I have only really tested the ActiveClients as that's all I needed. @BrendanGrant thanks, for making this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on information at https://ubntwiki.com/products/software/unifi-controller/start and my own testing, there appear to be a few minor differences between the APIs between the Windows/Linux run UniFi Controller and that on a UniFi OS based device
These changes include a couple of quirks as to how login/logoff work, as well as a slightly URL to hit APIs.
This PR introduces a way to be able to select which kind of controller will be connected to and adjust calls accordingly.
This has been tested against both an empty UniFi Controller running in a Windows virtual machine, as well as my Cloud Key Gen2 Plus (the only physical UFOS device I have access to).