Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Inline now saved #238

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Fix: Inline now saved #238

wants to merge 6 commits into from

Conversation

Jaddison011
Copy link

Summary

close #195

Checklist

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

  • Have you tested the changes? (pytest & dpytest)
  • Have you followed PEP-8 for naming and styling?
  • Has your code been properly documented with RestructuredText docstrings?
  • Have you added your changes to CHANGELOG.md under the [Unreleased] heading?
  • If your code added new bot commands, have you updated documentation.json?

  • All of this code is your own, or follows the author repo's licence.

@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #238 (72ea332) into master (3119f0d) will increase coverage by 0.13%.
The diff coverage is 65.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #238      +/-   ##
==========================================
+ Coverage   82.27%   82.40%   +0.13%     
==========================================
  Files          26       27       +1     
  Lines        6453     6560     +107     
==========================================
+ Hits         5309     5406      +97     
- Misses       1144     1154      +10     
Flag Coverage Δ
unittests 82.40% <65.38%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cogs/ReactForRole.py 48.65% <65.38%> (+0.64%) ⬆️
cogs/Verification.py 65.71% <0.00%> (-0.14%) ⬇️
cogs/IntroCog.py 85.18% <0.00%> (-0.14%) ⬇️
cogs/TextFilter.py 91.61% <0.00%> (-0.09%) ⬇️
conftest.py 100.00% <0.00%> (ø)
cogs/Voting.py 61.99% <0.00%> (ø)
cogs/TwitchAlert.py 58.06% <0.00%> (ø)
tests/test_KoalaBot.py 100.00% <0.00%> (ø)
tests/test_ColourRole.py 97.51% <0.00%> (ø)
tests/test_KoalaDBManager.py 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3119f0d...72ea332. Read the comment docs.

cogs/ReactForRole.py Outdated Show resolved Hide resolved
@@ -1078,9 +1110,19 @@ def create_tables(self):
UNIQUE (guild_id, role_id)
);
"""
sql_create_inline_all_status_table = """
CREATE TABLE IF NOT EXISTS InlineAllStatus (
guild_id integer NOT NULL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guild_id should be text, this is fine for now as I can change it later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best to change now, removes the need for changing later

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed guild_id to be text

@JayDwee
Copy link
Member

JayDwee commented Aug 18, 2021

Code coverage of tests needs increasing pls

@Kaspiaan Kaspiaan self-assigned this Oct 18, 2021
@VirajShah18 VirajShah18 marked this pull request as draft November 9, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline not saved
3 participants