Change Pola logo button behaviour

KlubJagiellonski · Aug 25, 2020 · eebfa1e · eebfa1e
1 parent 9c2a2c5
commit eebfa1e
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 3 deletions.
diff --git a/BuyPolish/Pola/Manager/Analytics/AnalyticsEventName.swift b/BuyPolish/Pola/Manager/Analytics/AnalyticsEventName.swift
@@ -8,5 +8,6 @@ enum AnalyticsEventName: String {
     case reportFinished = "report_finished"
     case menuItemOpened = "menu_item_opened"
     case donateOpened = "donate_opened"
+    case aboutPola = "about_pola"
     case polasFriends = "polas_friends"
 }
diff --git a/BuyPolish/Pola/Manager/Analytics/AnalyticsHelper.swift b/BuyPolish/Pola/Manager/Analytics/AnalyticsHelper.swift
@@ -63,6 +63,11 @@ final class AnalyticsHelper {
                  parameters: AnalitycsPolasFriendsParameters(device_id: UIDevice.current.deviceId))
     }
 
+    class func aboutPolaOpened() {
+        logEvent(name: .aboutPola,
+                 parameters: AnalitycsPolasFriendsParameters(device_id: UIDevice.current.deviceId))
+    }
+
     private class func reportParameters(barcode: String?) -> AnalyticsReportParameters {
         return AnalyticsReportParameters(code: barcode ?? "No Code",
                                          device_id: UIDevice.current.deviceId)

diff --git a/BuyPolish/Pola/SupportingFiles/pl.lproj/Localizable.strings b/BuyPolish/Pola/SupportingFiles/pl.lproj/Localizable.strings
@@ -68,6 +68,7 @@
 "Accessibility.Close" = "Zamknij";
 "Accessibility.CardHint" = "Otwórz lub zamknij poprzez kliknięcie";
 "Accessibility.Report.AddPhoto" = "Dodaj zdjęcie";
+"Accessibility.Logo" = "Strona główna";
 "CaptureVideo.Timer.Seconds" = "sek.";
 "CaptureVideo.Start" = "START";
 "CaptureVideo.Sending" = "Wysyłanie zdjęć";

diff --git a/BuyPolish/Pola/UI/ProductSearch/ScanCode/ScanCodeView.swift b/BuyPolish/Pola/UI/ProductSearch/ScanCode/ScanCodeView.swift
@@ -25,7 +25,7 @@ final class ScanCodeView: UIView {
 
         addSubview(dimView)
 
-        logoButton.accessibilityLabel = R.string.localizable.accessibilityPolaFriends()
+        logoButton.accessibilityLabel = R.string.localizable.accessibilityLogo()
         logoButton.setImage(R.image.logoIcon(), for: .normal)
         logoButton.sizeToFit()
         addSubview(logoButton)

diff --git a/BuyPolish/Pola/UI/ProductSearch/ScanCode/ScanCodeViewController.swift b/BuyPolish/Pola/UI/ProductSearch/ScanCode/ScanCodeViewController.swift
@@ -118,8 +118,8 @@ final class ScanCodeViewController: UIViewController {
 
     @objc
     func tapLogoButton() {
-        AnalyticsHelper.polasFriendsOpened()
-        let vc = AboutWebViewController(url: "https://www.pola-app.pl/m/friends",
+        AnalyticsHelper.aboutPolaOpened()
+        let vc = AboutWebViewController(url: "https://www.pola-app.pl/m/about",
                                         title: R.string.localizable.polaSFriends())
         vc.addCloseButton()
         let nvc = UINavigationController(rootViewController: vc)