SX1509: drop i2c modify bits #6684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the datasheet default value is 0000 0000 We do not modify them in other places. Signed-off-by: Timofey Titovets <[email protected]>
No longer used and niche Signed-off-by: Timofey Titovets <[email protected]>
|
Thanks. Seems useful to me. I believe the sx1509 was only used on the duet2 with the duex add-on board. It would be great if someone could confirm everything still works after this change. I'm not sure how many users there are now for that board. Maybe @ReXT3D would know? -Kevin |
|
Unfortunately I am unable to comment. I never used the sx1509 and both my Duet2 cards are currently not in active use. |
Merged
|
Thanks. -Kevin |
Misterke
pushed a commit
to Misterke/klipper
that referenced
this pull request
Nov 1, 2024
* sx1509: drop i2c_modify_bits According to the datasheet default value is 0000 0000 We do not modify them in other places. Signed-off-by: Timofey Titovets <[email protected]> * i2c: drop i2c_modify_bits No longer used and niche Signed-off-by: Timofey Titovets <[email protected]> --------- Signed-off-by: Timofey Titovets <[email protected]> Co-authored-by: Timofey Titovets <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i2c_modify_bits is tricky and used only in one place where it actually seems overcomplicated.
We do not modify registers in other places, they are reset before setting new bits.
So they can be simplified to i2c_write.
Datasheet: https://cdn.sparkfun.com/datasheets/BreakoutBoards/sx1509.pdf
Thanks.
#6674