Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klipper lib/stm32*: Update STM32 header references. #6673

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bevanweiss
Copy link
Contributor

The README referenced paths in a github that were themselves git submodules.
So have altered README to point to the referenced git repo itself rather than the containing git repo.

@bevanweiss bevanweiss force-pushed the update_stm32_headers branch 2 times, most recently from dbe3f1c to 48a9c9b Compare August 30, 2024 09:29
The README referenced paths in a github that were themselves git submodules.
So have altered README to point to the referenced git repo itself rather
than the containing git repo.


Signed-off-by: Bevan Weiss <[email protected]>
Copy link

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

@KevinOConnor
Copy link
Collaborator

Alas, the STM provided code is of low-quality. The code often has bugs, they don't publish meaningful changelogs, they frequently change the license statements (often making them more ambiguous), and they have a history of changing the repo locations.

As near as I can tell the current Klipper lib/README file is accurate (one can obtain the code from the given repos by checking out the specified commit). Until that changes or some new functionality requires an update, I would avoid "chasing" STM's changes.

Thanks,
-Kevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants