Pep 420 style updates #789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also locally install a trame-client fork for demonstration
jcapriot
commented
Aug 20, 2025
Comment on lines
+59
to
+85
| - name: Checkout trame-client fork for testing | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: jcapriot/trame-client | ||
| ref: Pep420 | ||
| path: local_trame_client | ||
|
|
||
| - name: Install trame-client fork for testing | ||
| run: | | ||
| cd local_trame_client | ||
| cd vue2-app | ||
| npm ci | ||
| npm run build | ||
| cd .. | ||
| cd vue3-app | ||
| npm ci | ||
| npm run build | ||
| cd .. | ||
| pip install . | ||
| - name: Install and Run Tests | ||
| run: | | ||
| pip install ".[dev]" | ||
| pip install -r tests/requirements.txt | ||
| # Run the tests with coverage so we get a coverage report too | ||
| pip install coverage | ||
| coverage run --source . -m pytest . | ||
| coverage run --source . -m pytest . --ignore=local_trame_client |
Author
There was a problem hiding this comment.
This should be removed before merging, it's just to demonstrate that it works with the changes proposed in the matching PR to trame-client
jcapriot
force-pushed
the
pep420
branch
2 times, most recently
from
3c991db to
f5427c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove's legacy implicit namespace mechanisms.
Relies on
trame-clientproviding the__init__.pyfortrame,trame.modules,trame.ui, andtrame.widgets