Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge polygons #617

Merged
merged 9 commits into from
Jul 9, 2024
Merged

Merge polygons #617

merged 9 commits into from
Jul 9, 2024

Conversation

PaulHax
Copy link
Collaborator

@PaulHax PaulHax commented Jun 27, 2024 •
edited
Loading

Right click to merge selected polygons.

Adds a new deprendency polybool =/

closes #614

@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 50d897f
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/668c5f2e5badc0000826eb91
😎 Deploy Preview https://deploy-preview-617--volview-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@floryst
Copy link
Collaborator

floryst commented Jun 27, 2024

Functionality-wise, seems good so far. Is there existing software that merges polygons, and what is the desired behavior post-merge?

@PaulHax
Copy link
Collaborator Author

PaulHax commented Jun 27, 2024

Is there existing software that merges polygons

HistomicsUI large image viewer. <- Behavior is different though as Histomics has a named annotation that can be made up of multiple vector shapes. Drawn vector shapes are automaticly merged.

What is the desired behavior post-merge?

Currently polygon store is deleting selected polygons and creating a new polygon. Is that what you mean?

@floryst
Copy link
Collaborator

floryst commented Jul 2, 2024

Currently polygon store is deleting selected polygons and creating a new polygon. Is that what you mean?

I'm referring to the connectivity visually looking like a line that has to be teased apart to reveal the connection point. I'm just curious if there are other merging strategies that other software uses.

Other than that, LGTM

@PaulHax
Copy link
Collaborator Author

PaulHax commented Jul 3, 2024

New additions:

  • Only allow merging if polygons overlap.
  • Hold g key to merge freshly placed polygon with overlapping poygons.

Good to go by me.

floryst
floryst reviewed Jul 3, 2024
View reviewed changes
src/components/tools/polygon/PolygonTool.vue Outdated Show resolved Hide resolved
src/composables/actions.ts Outdated Show resolved Hide resolved
@PaulHax
feat(polygons): make merge key configurable
11d93ed 
Adds pan slice views with middle mouse button besides
shift + left mouse button.  This is because polygon tool
consumes mouse events even with shift pressed.
@PaulHax PaulHax mentioned this pull request Jul 5, 2024
Merged
@floryst
Copy link
Collaborator

floryst commented Jul 9, 2024

@PaulHax is this ready? I see some new changes since the last approval.

@PaulHax
Copy link
Collaborator Author

PaulHax commented Jul 9, 2024

Yes, its ready. The new changes

  • Hold Shift key to merge
  • Different polygon library

@floryst floryst added this pull request to the merge queue Jul 9, 2024
Merged via the queue into Kitware:main with commit 72bf66b Jul 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryst floryst floryst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Merge polygons new feature
2 participants
@PaulHax @floryst