Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(WindowLevelTool): swap W/L controls #334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(WindowLevelTool): swap W/L controls #334

wants to merge 1 commit into from

Conversation

floryst
Copy link
Collaborator

@floryst floryst commented May 24, 2023

Swaps Window and Level controls.

@floryst floryst requested review from aylward and PaulHax May 24, 2023 19:04
@netlify
Copy link

netlify bot commented May 24, 2023 •
edited
Loading

✅ Deploy Preview for volview-dev ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/646e628a423fed1248f7ee10
😎 Deploy Preview https://deploy-preview-334--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

PaulHax
PaulHax approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@PaulHax PaulHax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always wondered what was the convention.

When I drag the mouse down, the image gets darker lighter. Should the level direction be inverted?

@floryst
Copy link
Collaborator Author

floryst commented May 25, 2023

I'm not 100% sure. I need to check to see if it's consistent across other viewers.

@PaulHax
Copy link
Collaborator

PaulHax commented Jun 9, 2023 •
edited
Loading

Level decreases with mouse moving down, matching current behavior:

Increases the level with the mouse moving down. Opposite of current behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulHax PaulHax PaulHax approved these changes

@aylward aylward Awaiting requested review from aylward

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floryst @PaulHax