Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HeaderProtocol to support flexible header definitions #84

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

markm77
Copy link

@markm77 markm77 commented Dec 7, 2019

Adds HeaderProtocol to allow external Header definitions to be used as well as encode() overriding. This change aligns header structure to that used for claims.

@markm77 markm77 mentioned this pull request Dec 7, 2019
@markm77
Copy link
Author

markm77 commented Dec 7, 2019

You can see an example use of the flexible header here: https://github.com/finlabsuk/open-banking-connector/blob/master/Sources/OpenBankingConnector/jws.swift.

(I've temporarily made the OBC project dependent on the fork.)

@@ -46,11 +46,11 @@ public struct JWT<T: Claims>: Codable {
/// - Parameter header: A JSON Web Token header object.
/// - Parameter claims: A JSON Web Token claims object.
/// - Returns: A new instance of `JWT`.
public init(header: Header = Header(), claims: T) {
public init(header: H, claims: T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. Is it possible to retain the default value for header so that it is non-breaking? (ie. the tests should not have to change, unless you are adding one to test the new facility).

@CLAassistant
Copy link

CLAassistant commented Apr 5, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mark Murphy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants