Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Fillet AST Mod to Async Actor #4803

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

max-mrgrsk
Copy link
Collaborator

@max-mrgrsk max-mrgrsk commented Dec 15, 2024

Description:

Convert the fillet AST mod from a synchronous XState action to an asynchronous actor.
This removes ESLint exceptions and ensures proper async handling.

Closes: #4749
Project: #2606

Copy link

qa-wolf bot commented Dec 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Dec 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Dec 18, 2024 1:46pm

@max-mrgrsk max-mrgrsk self-assigned this Dec 15, 2024
@max-mrgrsk max-mrgrsk added refactor ast Issues / features relevant to ast and parser. xstate Bugs and issues related to xstate. labels Dec 15, 2024
@max-mrgrsk max-mrgrsk added this to the v1 Modeling App Launch milestone Dec 15, 2024
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.84%. Comparing base (3630696) to head (758dc81).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4803   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files          86       86           
  Lines       30893    30893           
=======================================
  Hits        26519    26519           
  Misses       4374     4374           
Flag Coverage Δ
wasm-lib 85.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@max-mrgrsk
Copy link
Collaborator Author

One test keeps failing. The rest is ok.

@max-mrgrsk max-mrgrsk requested a review from Irev-Dev December 16, 2024 06:54
@pierremtb
Copy link
Collaborator

Took the liberty to trigger the CI again after the updated snaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ast Issues / features relevant to ast and parser. refactor xstate Bugs and issues related to xstate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert ast fillet from xstate action to async actor and remove eslint disabling comments
2 participants