fix: remove noisy log line in linux #4725
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4024
At first, I thought this was something that should just get skipped on Linux, because Bonjour is a Windows/Mac app, but it seems like the library is using Bonjour to refer to zeroconf networking in general. So, it should work, but it doesn't seem like the success callback ever actually gets triggered on Linux. It also doesn't seem to trigger any sort of error behavior. I have the avahi-daemon installed and running and can see a local printer by running
ippfind, so not entirely sure what the deal is. Seems like thebonjour-servicelibrary is expecting there to be aPTRrecord for the mdns server, but avahi doesn't supply one, so the library returns nullSo, this just removes that logline because it's spammy. I can open an issue about the machine finding if y'all think that's worth looking at