Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish read and deser errors in engine websocket #2640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adamchalmers
Copy link
Collaborator

Fixes #2639

Copy link

qa-wolf bot commented Jun 10, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jun 10, 2024 8:31pm

@jessfraz
Copy link
Contributor

@adamchalmers can you rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebSocket to engine must distinguish between connection/deserialization errors
2 participants