Skip to content

Restore editable Shift+T shortcut for Feature Tree - #13959

Open
patch-goblin[bot] wants to merge 3 commits into
mainfrom
patch-goblin/slack/97fd76ae-2f79-4db9-90f9-6ba336811a1d
Open

patch-goblin[bot] wants to merge 3 commits into
mainfrom
patch-goblin/slack/97fd76ae-2f79-4db9-90f9-6ba336811a1d

Conversation

@patch-goblin

@patch-goblin patch-goblin Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Restores the requested Feature Tree pane shortcut as an editable registry keybinding owned by the featureTree extension.

  • Register Toggle Feature Tree with default Shift+T in modeling/sketch contexts, using the layout service and existing pane toggle helper to show/hide the entire operations-and-bodies pane.
  • Expose the binding through the normal Keybindings settings so users can rebind or unbind it. Text-editing contexts keep uppercase T for typing.
  • Remove the old area-level shortcut declaration so legacy simple-pane layouts cannot register a competing, non-editable handler. Other sidebar shortcuts are unchanged.

History

The shortcut really existed: git blame traces keybinding: 'Shift + T' to the original Feature Tree PR, #4782 on December 20, 2024. #9899 converted the pane from Simple to Splits to contain operations and bodies. The legacy PaneButton shortcut path still only resolves Simple area definitions, leaving the old declaration disconnected for the split pane.

Regression evidence and review notes

51 focused unit tests pass, including default/Playwright layout toggle round trips, sibling preservation, typing/context exclusions, and rebinding/unbinding through the settings-row conversion. Removing the new keymap contribution produces seven expected failures (unmatched shortcut and missing editable settings row); restoring it passes. Targeted ESLint/Biome and the repository circular-dependency check pass. Two independent read-only reviews found no blocking issues.

Full npm run tsc is not clean in this fresh checkout because of missing generated Rust/Wasm bindings and dependency declarations, including vscode-languageserver-protocol. A detached unchanged main checkout produces exactly the same diagnostics, with no added errors from this change.

The unit tests exercise registry contributions, keymap matching, settings conversion, and layout mutation, not the full UI keyboard dispatcher or disk persistence. Before marking ready, smoke-test Shift+T twice, uppercase T while typing, and a rebound shortcut after settings reload. No engine-backed UI test was run locally.

@vercel

vercel Bot commented Sep 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Sep 17, 2026 12:23pm UTC

Request Review

@pierremtb pierremtb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

The keybindings works great on Vercel but we're missing it in the tooltip I think?

Co-authored-by: Patch Goblin <patch-goblin@users.noreply.github.com>

This branch was successfully deployed

1 active deployment
Preview — ce668fa7 Deployed Sep 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant