Repository navigation
Restore editable Shift+T shortcut for Feature Tree - #13959
Open
patch-goblin[bot] wants to merge 3 commits into
Open
patch-goblin[bot] wants to merge 3 commits into
patch-goblin[bot] wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
reviewed
Sep 17, 2026
Co-authored-by: Patch Goblin <patch-goblin@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Restores the requested Feature Tree pane shortcut as an editable registry keybinding owned by the
featureTreeextension.Shift+Tin modeling/sketch contexts, using the layout service and existing pane toggle helper to show/hide the entire operations-and-bodies pane.Tfor typing.History
The shortcut really existed:
git blametraceskeybinding: 'Shift + T'to the original Feature Tree PR, #4782 on December 20, 2024. #9899 converted the pane fromSimpletoSplitsto contain operations and bodies. The legacyPaneButtonshortcut path still only resolvesSimplearea definitions, leaving the old declaration disconnected for the split pane.Regression evidence and review notes
51 focused unit tests pass, including default/Playwright layout toggle round trips, sibling preservation, typing/context exclusions, and rebinding/unbinding through the settings-row conversion. Removing the new keymap contribution produces seven expected failures (unmatched shortcut and missing editable settings row); restoring it passes. Targeted ESLint/Biome and the repository circular-dependency check pass. Two independent read-only reviews found no blocking issues.
Full
npm run tscis not clean in this fresh checkout because of missing generated Rust/Wasm bindings and dependency declarations, includingvscode-languageserver-protocol. A detached unchangedmaincheckout produces exactly the same diagnostics, with no added errors from this change.The unit tests exercise registry contributions, keymap matching, settings conversion, and layout mutation, not the full UI keyboard dispatcher or disk persistence. Before marking ready, smoke-test
Shift+Ttwice, uppercaseTwhile typing, and a rebound shortcut after settings reload. No engine-backed UI test was run locally.