Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert ast fillet from xstate action to async actor and remove eslint disabling comments #4749

Open
Tracked by #2606
max-mrgrsk opened this issue Dec 11, 2024 · 0 comments · May be fixed by #4803
Open
Tracked by #2606

convert ast fillet from xstate action to async actor and remove eslint disabling comments #4749

max-mrgrsk opened this issue Dec 11, 2024 · 0 comments · May be fixed by #4803
Assignees
@max-mrgrsk
Labels
ast Issues / features relevant to ast and parser. xstate Bugs and issues related to xstate.
Milestone
v1 Modeling App L...

Comments

@max-mrgrsk
Copy link
Collaborator

max-mrgrsk commented Dec 11, 2024 •
edited
Loading

Convert the AST fillet implementation from a synchronous XState action to an asynchronous actor, removing the need for eslint disabling comments. This refactoring ensures proper awaiting of async tasks and aligns with our newer coding practices demonstrated in recent PRs.

Discussion: #4694 (review)
Reference: https://github.com/KittyCAD/modeling-app/pull/4666/files#diff-5b3927b16824249515f7aa8762bd6c9c9ba641a023bb6d0a75b75331326cf4aa
@max-mrgrsk max-mrgrsk mentioned this issue Dec 11, 2024
Open
45 tasks
@max-mrgrsk max-mrgrsk self-assigned this Dec 11, 2024
@max-mrgrsk max-mrgrsk added xstate Bugs and issues related to xstate. ast Issues / features relevant to ast and parser. labels Dec 11, 2024
@max-mrgrsk max-mrgrsk added this to the v1 Modeling App Launch milestone Dec 11, 2024
@max-mrgrsk max-mrgrsk changed the title convert ast chamfer from xstate action to async actor and remove eslint disabling comments convert ast fillet from xstate action to async actor and remove eslint disabling comments Dec 11, 2024
@max-mrgrsk max-mrgrsk mentioned this issue Dec 11, 2024
Open
3 tasks
@max-mrgrsk max-mrgrsk linked a pull request Dec 15, 2024 that will close this issue
Refactor Fillet AST Mod to Async Actor #4803
Draft
@max-mrgrsk max-mrgrsk linked a pull request Dec 15, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-mrgrsk max-mrgrsk

Labels
ast Issues / features relevant to ast and parser. xstate Bugs and issues related to xstate.
Projects
None yet
Milestone
v1 Modeling App Launch
Development

Successfully merging a pull request may close this issue.

Refactor Fillet AST Mod to Async Actor KittyCAD/modeling-app
1 participant
@max-mrgrsk