-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project to plane #587
base: main
Are you sure you want to change the base?
project to plane #587
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
=======================================
Coverage ? 24.07%
=======================================
Files ? 35
Lines ? 2023
Branches ? 0
=======================================
Hits ? 487
Misses ? 1536
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -809,6 +809,19 @@ define_modeling_cmd_enum! { | |||
pub curve_id: Uuid, | |||
} | |||
|
|||
/// Project an entity on to a plane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could use a bit more detail or an example of its use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example or in the comments of the endpoint? Projecting a point onto a plane is where you calculate the normal between a plane and a point that does not lie on the plane. You then move that point along the normal until it is now lying on the plane exactly.
Useful for constraints, shadows, intersection testing, etc.p
Endpoint to allow entity to be projected onto a plane
https://github.com/KittyCAD/engine/issues/2663