Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project to plane #587

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

project to plane #587

wants to merge 3 commits into from

Conversation

benjamaan476
Copy link
Contributor

Endpoint to allow entity to be projected onto a plane

https://github.com/KittyCAD/engine/issues/2663

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d24f88d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/def_enum.rs 0.00% 1 Missing ⚠️
modeling-cmds/src/ok_response.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage        ?   24.07%           
=======================================
  Files           ?       35           
  Lines           ?     2023           
  Branches        ?        0           
=======================================
  Hits            ?      487           
  Misses          ?     1536           
  Partials        ?        0           
Flag Coverage Δ
unittests 24.07% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -809,6 +809,19 @@ define_modeling_cmd_enum! {
pub curve_id: Uuid,
}

/// Project an entity on to a plane.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a bit more detail or an example of its use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An example or in the comments of the endpoint? Projecting a point onto a plane is where you calculate the normal between a plane and a point that does not lie on the plane. You then move that point along the normal until it is now lying on the plane exactly.

Useful for constraints, shadows, intersection testing, etc.p

@benjamaan476 benjamaan476 self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants