Use standard Python tool to build Python extension #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can produce *.so file and include resources files now. But not link to enough libraries yet.
Remain issue: model files are not included yet.
|
In this PR, I make change of folder layout under swig/Python(3). It is explained here fossasia/susi_linux#326 (comment). |
|
Could you consider this @chenguoguo ? This PR supersedes #475 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix #491
Here are the build logs, when building wheel package with this new setup.py script.
On Raspberry Pi 3 (armv7l): https://paste.ee/p/aadtr
On Mac OS X 10.12: https://paste.ee/p/dRAYk
On Ubuntu 18.04 (x86_64): https://paste.ee/p/9Tx5H
The produced .whl files are uploaded here: https://gemfury.com/fossasia/python:snowboy