V1.4.0 #464
Open
V1.4.0 #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eqiihuu
commented
Jul 3, 2018
eqiihuu
commented
- add KwdSampleStart & KwdSampleEnd in the header and library files
- add keyword start & end frame_ID in logs
- update pre-compiled binaries and libraries
chenguoguo
reviewed
Jul 7, 2018
include/snowboy-detect.h
Outdated
| // sensitivity, the algorithm automatically chooses between the normal | ||
| // sensitivity set above and the higher sensitivity set here, to maximize the | ||
| // performance. By default, it is not set, which means the algorithm will | ||
| // stick with the sensitivity set above. |
There was a problem hiding this comment.
Let's leave those comments here.
include/snowboy-detect.h
Outdated
| // processing, it may decrease the performance. The general rule of thumb is: | ||
| // 1. For personal models, set it to false. | ||
| // 2. For universal models, follow the instruction of each published model | ||
| // otherwise turns the audio processing off. |
There was a problem hiding this comment.
Let's leave those comments here.
There was a problem hiding this comment.
Got it. Do we also need to add these comments back in the snowboy-detect.h.template?
|
Is there any progress on the new version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.