Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Python extension with setuptools #491

Open
hongquan opened this issue Aug 9, 2018 · 0 comments · May be fixed by #493
Open

Build Python extension with setuptools #491

hongquan opened this issue Aug 9, 2018 · 0 comments · May be fixed by #493

Comments

@hongquan
Copy link

hongquan commented Aug 9, 2018

Currently, in setup.py, you still use make to build the .so file for Python extension. The problem with that approach is that, it generates wheel package with wrong filename, make pip not able to pick the right file for the platform. So I plan to rewrite the build script, using distutils.core.Extension. What do you think?
@hongquan hongquan linked a pull request Aug 13, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use standard Python tool to build Python extension fossasia/snowboy
1 participant
@hongquan