feat(checkpoint): add storage checkpoint API#314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
KiteSQL did not expose a storage-level checkpoint API, which made it harder to take online consistent snapshots from native embeddings.
Issue link:
What is changed and how it works?
CheckpointableStorageandDatabase::checkpoint(path)so checkpoint support is exposed as an optional storage capability.build_optimistic()uses RocksDB's safe checkpoint path.build_rocksdb()is gated behindunsafe_txdb_checkpointbecause upstreamrocksdbdoes not expose a safeTransactionDBcheckpoint API.build.rsguard sounsafe_txdb_checkpointonly builds with the currently validatedrocksdbandlibrocksdb-sysversions inCargo.lock.docs/features.md, keep the README summary short, and bumpkite_sqlto0.2.1.Code changes
Check List
Tests
Side effects
Note for reviewer
Validation used for this branch:
cargo test checkpoint -- --nocapturecargo test --features unsafe_txdb_checkpoint checkpoint -- --nocapture