fix(auth): keep development login panel in flow on phone viewports - #6427
Merged
iscekic merged 1 commit intoSep 21, 2026
Conversation
iscekic
marked this pull request as draft
September 20, 2026 13:01
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit 504b11c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 504b11c)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe phone-viewport fix is sound, but the Overview
Issue Details (click to expand)WARNING
Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
force-pushed
the
kwf/explorer-signin-devicelink-the-development-login-panel-ov-1a2c7-4140
branch
from
September 20, 2026 15:11
504b11c to
e7bb5ea
Compare
iscekic
marked this pull request as ready for review
September 20, 2026 15:32
eshurakov
approved these changes
Sep 21, 2026
eshurakov
left a comment
Contributor
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
iscekic
deleted the
kwf/explorer-signin-devicelink-the-development-login-panel-ov-1a2c7-4140
branch
September 21, 2026 14:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
smup the panel returned to afixed bottom-6 left-6overlay, which still covered the centeredmax-w-smform at tablet widths. Thesm:overlay classes are removed, so the panel stays in the page flow at every width.fixedorsm:fixedutility re-floats it.relativestill anchors the close button, and the opaquebg-gray-900background still blocks page text.fixedor ends with:fixed, replacing the old phone-flow andsm-float expectations.smup and only stayed in flow on phones.E2E proof
Owner request
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e1-signin-768x1024-cdp.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e2-signin-1280x720-cdp.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e2-signin-375x667-cdp.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e2-signin-baseline-ab-cdp.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e2-signin-breakpoints-cdp.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-review-b49a/e2e-mobile-app/e2-signin-375x667.txt