Repository navigation
Conversation
Explorer finding: pr-review-inbox: The 'Pull request' badge on the inbox row runs into the right screen edge with no right margin and no visible rounded corner. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: pr-review-inbox Found on revision: 5327758 Repro: 1. set this state first: uimode night; size 720x1600; battery 15 discharging; rotate portrait; relaunch; back; the device in dark mode 2. open the app on emulator-5554 3. reach pr-review-inbox 4. the capture shows the defect named below Observed: The 'Pull request' badge on the inbox row runs into the right screen edge with no right margin and no visible rounded corner. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482b01/pr-review-inbox.png
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed a two-file mobile change that makes the inbox row's ref · age text the flexible value ( Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
eshurakov
left a comment
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
…-badge-on-the-in-46482-cd62
…-badge-on-the-in-46482-cd62
Changelog for users
Changelog for maintainers
E2E proof
[e1] On a 360dp dark phone, the inbox long-ref row's 'Pull request' chip sits inside the row, rounded end visible, clear of the screen edge — android emulator-5554, 720x1600@320dpi (360dp) night (e1-device-state.log: 'Override size: 720x1600', 'Night mode: yes'); stub inbox (e1-stub-start.log, e1-checks.log ok:true count:1). e1-scene.log 'SCENE e1 OK': row 'kilo-stub/discussion-conversation-only#2 · 6 months ago' [42,747][476,775] with chip 'Pull request' [504,747][611,775]; chip right ~627 is inside the row content edge 678 (Open [42,397][678,485]) and 93px clear of the 720px edge; ref text shrank (434px/54 chars vs 426px/42 chars] so the chip keeps its full 107px width. Packed tree, no staging edit. No UX-DEFECT in the digest…
[e2] Draft inbox row renders both 'Pull request' and 'Draft' chips inside the row with no clipping — android emulator-5554, 720x1600@320dpi (360dp) night (e2-device-state.log). Stub cannot yield a draft INBOX row (server.mjs inboxNode hardcodes isDraft:false), so the draft state was created with a temporary toGitHubInboxRows fixture in apps/mobile/src/lib/pr-review/use-provider-inbox.ts and reverted (git status clean). e2-scene.log 'SCENE e2 OK': ref [42,747][389,775], chips 'Pull request' [417,747][524,775] and 'Draft' [566,747][611,775]; rightmost chip right ~627 is inside the row content edge 678 and clear of the 720 edge, both chips full width (107/45px). No UX-DEFECT in the digest…
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e1-device-state.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e1-stub-start.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e1-checks.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e2-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-review-inbox-the-pull-request-badge-on-the-in-46482-cd62/e2e-mobile-app/e2-device-state.logOwner request
Follow-ups (not changed here)
Open findings (not fixed here)