Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Previous Review Summary (commit c048725)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c048725)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (6 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
marked this pull request as draft
September 19, 2026 21:00
iscekic
added a commit
that referenced
this pull request
Sep 19, 2026
iscekic
force-pushed
the
kwf/explorer-signin-email-pasted-submit-the-same-error-bar-si-5bf10-1568
branch
from
September 19, 2026 21:25
c048725 to
27c9640
Compare
iscekic
force-pushed
the
kwf/explorer-signin-email-pasted-submit-the-same-error-bar-si-5bf10-1568
branch
from
September 19, 2026 21:58
27c9640 to
883c001
Compare
iscekic
marked this pull request as ready for review
September 19, 2026 22:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
defaultValuefrom the live email ref, so the rejected address stays visible under its inline error; the mounted-field test asserts that value.emailErrorplusclearEmailError; empty,INVALID_REQUEST, andINVALID_EMAILresults stay beside the field, while other failures still use a toast.FormFieldaccepts optionalreserveErrorMessages; it renders hidden full-width copies of the localized copy to reserve the tallest height, positions the live message over that band, and hides the copies from accessibility so the error is announced once.IdleAuthreserves the empty-email, invalid-request, and invalid-email copy and returns to the main view when an address error arrives from a resend, so feedback is not hidden behind code entry.E2E proof
Owner request
E2E proof — log excerpts