Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added EFM8UB3 Devices #2804

Merged
merged 12 commits into from
Sep 5, 2020
Merged

Conversation

LeSpirou
Copy link
Contributor

Added three MCU devices to MCU_SiliconLabs: EFM8UB31F40G-A -QFN20, -Q…

…FN24, -QSOP24

Violated KLC Rules:
S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50)

Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf

grafik
grafik
grafik


All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • Provide a screenshot of the symbol(s) from the symbol editor with the pin types visible
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.

LeSpirou added 9 commits June 12, 2020 20:20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Removed all footprint filters since there are already compatible ones associated with.
Centered all symbols.
Fixed the doubled Pin 24 in the QSOP24.
Rechecked all pin numbers and associated names.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Added apropriate footprint filters.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
However they are all off center by +10mil in Y axis to maintain the 100mil pin grid and symmetry.
…FN24, -QSOP24

Violated KLC Rules:
S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50)

Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf
@LeSpirou LeSpirou changed the title Added EFM8UB31F40G-A.. Added EFM8UB3 Devices Jun 16, 2020
@myfreescalewebpage myfreescalewebpage added Addition Adds new symbols to library Pending reviewer A pull request waiting for a reviewer labels Jun 17, 2020
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Changed VDD from Power Input to Passive since it can source power from the internal 5V LDO regulator aswell.
@LeSpirou
Copy link
Contributor Author

Violated KLC Rules:
S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50)
S4.4 Reason: VDD pin has the electrical passive since it does also source power, depending on the configuation.

@myfreescalewebpage myfreescalewebpage self-assigned this Aug 24, 2020
@myfreescalewebpage myfreescalewebpage removed the Pending reviewer A pull request waiting for a reviewer label Aug 24, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Aug 24, 2020

Hi @LeSpirou , thanks for contributing,

A few comments I have during my review:

EFM8UB30F40G-A-QFN20

  • Description should ends with package name 8051-compatible microcontroller, 48 MHz, 2.3 to 5.5V, 40K flash, 3.25K RAM, -40 to +85 C, QFN-20 is great
  • Fp filter: SiliconLabs*QFN*1EP*3x3mm*P0.5mm*
  • Pins length should be 100 mil for this symbol (< 100 pins)
  • VDD should be Power Input
  • Pin 11 is missing
  • Pins 9 and 10 should be Bidirectionnal
  • You should order pins by groups (P2.x together, etc) with a separation of 200mil between groups. PLease separate also USB pins, this is another group

EFM8UB31F40G-A-QFN24

  • Description should ends with package name 8051-compatible microcontroller, 48 MHz, 2.3 to 5.5V, 40K flash, 3.25K RAM, -40 to +85 C, QFN-24 is great
  • Fp filter: QFN*1EP*4x4mm*P0.5mm*
  • Pins length should be 100 mil for this symbol (< 100 pins)
  • VDD should be Power Input
  • Pins 9 and 10 should be Bidirectionnal
  • You should order pins by groups (P2.x together, etc) with a separation of 200mil between groups. PLease separate also USB pins, this is another group

EFM8UB31F40G-A-QFN24

  • Description should ends with package name 8051-compatible microcontroller, 48 MHz, 2.3 to 5.5V, 40K flash, 3.25K RAM, -40 to +85 C, QSOP-24 is great
  • Fp filter: QSOP*3.9x8.7mm*P0.635mm*
  • Pins length should be 100 mil for this symbol (< 100 pins)
  • VDD should be Power Input
  • Pins 11 and 12 should be Bidirectionnal
  • You should order pins by groups (P2.x together, etc) with a separation of 200mil between groups. PLease separate also USB pins, this is another group

Cheers,
Joel

LeSpirou added 2 commits August 30, 2020 14:26
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
Adjusted description and filter accordingly
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24
MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24

Grouped pins according their ports and major purpose.
Changed electrical type of VDD from passive to power input.
Changed electrical type of C2K and C2D to bidirectional.
Changed pin length from 150mil to 100mil.

Violated KLC Rules:
S3.1: Smybols are off-centered by (0, 50) in order to maintain 100mil grid.

EFM8UB30F40G-A-QFN20
Added missing pin 11 (P1.2)
@LeSpirou
Copy link
Contributor Author

EFM8UB30F40G-A-QFN20

EFM8UB31F40G-A-QFN24

EFM8UB31F40G-A-QSOP24

@LeSpirou
Copy link
Contributor Author

@myfreescalewebpage Hi Joel
I adjusted the symbols according your comments. Just to let you know.

@myfreescalewebpage
Copy link
Collaborator

Great job done ! No more comment, merging.

@myfreescalewebpage myfreescalewebpage merged commit aa4e12e into KiCad:master Sep 5, 2020
@LeSpirou LeSpirou deleted the EFM8UB31F40G branch September 10, 2020 14:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants