This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QFN20
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Removed all footprint filters since there are already compatible ones associated with. Centered all symbols. Fixed the doubled Pin 24 in the QSOP24. Rechecked all pin numbers and associated names.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Added apropriate footprint filters.
MCU_SiliconLabs:EFM8UB31F40G-A-QFN20 MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 However they are all off center by +10mil in Y axis to maintain the 100mil pin grid and symmetry.
…FN24, -QSOP24 Violated KLC Rules: S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50) Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf
… (note the second appearing digit)
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Changed VDD from Power Input to Passive since it can source power from the internal 5V LDO regulator aswell.
Violated KLC Rules: |
Hi @LeSpirou , thanks for contributing, A few comments I have during my review: EFM8UB30F40G-A-QFN20
EFM8UB31F40G-A-QFN24
EFM8UB31F40G-A-QFN24
Cheers, |
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Adjusted description and filter accordingly
MCU_SiliconLabs:EFM8UB31F40G-A-QFN24 MCU_SiliconLabs:EFM8UB31F40G-A-QSOP24 Grouped pins according their ports and major purpose. Changed electrical type of VDD from passive to power input. Changed electrical type of C2K and C2D to bidirectional. Changed pin length from 150mil to 100mil. Violated KLC Rules: S3.1: Smybols are off-centered by (0, 50) in order to maintain 100mil grid. EFM8UB30F40G-A-QFN20 Added missing pin 11 (P1.2)
@myfreescalewebpage Hi Joel |
Great job done ! No more comment, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added three MCU devices to MCU_SiliconLabs: EFM8UB31F40G-A -QFN20, -Q…
…FN24, -QSOP24
Violated KLC Rules:
S3.1 Reason: To maintain the 100mil pin grid spacing all symbols off centered by (0,+50)
Datasheet: https://www.silabs.com/documents/public/data-sheets/efm8ub3-datasheet.pdf
All contributions to the kicad library must follow the KiCad library convention
Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:
Be patient, we maintainers are volunteers with limited time and need to check your contribution against the datasheet. You can speed up the process by providing all the necessary information (see above). And you can speed up the process even more by providing additional info like the screenshot of the symbol editor pin table (or for high pin counts converted to csv) sorted in the same way as the pin table in the datasheet and a direct link to the datasheet page that contains the pin table.