Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Added STM8S208CB with aliases #2610

Merged
merged 10 commits into from
Apr 5, 2020
Merged

Conversation

aris-kimi
Copy link
Collaborator

@aris-kimi aris-kimi commented Apr 5, 2020

Aliases are:
STM8S208C8
STM8S208C6
STM8S207CB
STM8S207C8
STM8S207C6
Datasheet: https://www.st.com/resource/en/datasheet/stm8s208cb.pdf

All contributions to the kicad library must follow the KiCad library convention

Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the symbol(s) you are contributing
  • An example screenshot image is very helpful
  • Ensure that the associated footprints match the official footprint library
    • A new fitting footprint must be submitted if the library does not yet contain one.
  • If there are matching footprint PRs, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required
  • Give a reason behind any intentional library convention rule violation.

@aris-kimi
Copy link
Collaborator Author

stm8s

@aris-kimi
Copy link
Collaborator Author

Hi there @myfreescalewebpage. Since i kept the engine running... Have a look please... Thank you for the patience!!

@myfreescalewebpage myfreescalewebpage self-assigned this Apr 5, 2020
@myfreescalewebpage myfreescalewebpage added the Addition Adds new symbols to library label Apr 5, 2020
@myfreescalewebpage
Copy link
Collaborator

myfreescalewebpage commented Apr 5, 2020

@aris-kimi only one comment:

  • You can decrease the height of the symbol by 100mil at the bottom, so you will have the VCAP at 100mil of the corner, as done with the previous PR. This will also permit to fix the travis warning.

Else, perfect, no comment to do!

Joel

@aris-kimi
Copy link
Collaborator Author

@myfreescalewebpage will it be ok to decrease the height by 200mill and transfer both vcap and reset to the right side in order to have symmetry in the body?

@aris-kimi
Copy link
Collaborator Author

aris-kimi commented Apr 5, 2020

stm8s

...more than 200mil reduced, what do you think?

I will upload new edited files after your approval @myfreescalewebpage

@myfreescalewebpage
Copy link
Collaborator

@aris-kimi it's also ok for me

Also fixed design issue.
@aris-kimi
Copy link
Collaborator Author

@myfreescalewebpage i think we are done. Thank you for the assistance.

@myfreescalewebpage
Copy link
Collaborator

Thanks for the quick fixes. Maybe the fastest pull request of the KiCad history !

@myfreescalewebpage myfreescalewebpage merged commit 9cbfbc2 into KiCad:master Apr 5, 2020
@aris-kimi aris-kimi deleted the stm8s207_8 branch April 5, 2020 22:46
@antoniovazquezblanco antoniovazquezblanco added this to the 5.1.6 milestone Apr 6, 2020
jamesrlucas pushed a commit to jamesrlucas/kicad-symbols that referenced this pull request Apr 20, 2020
* Design errors corrected

Also added R8 and R6 aliases. It is only memory option.

* Add files via upload

* Added STM8S208CB with aliases

* Added STM8S208CB with aliases

Also fixed design issue.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Addition Adds new symbols to library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants