Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing constants to the enum tests #3692

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Add missing constants to the enum tests #3692

merged 1 commit into from
Sep 26, 2024

Conversation

lexaknyazev
Copy link
Member

Some of the used constants were undefined thus they were not actually tested. The fixed test fails on Chromium and WebKit.

@lexaknyazev
Copy link
Member Author

/cc @kkinnunen-apple

kenrussell
kenrussell approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@kenrussell kenrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the test. Looks good to me.

I filed crbug.com/369766154 about this on the Chromium side.

@kenrussell kenrussell merged commit 0f39bef into KhronosGroup:main Sep 26, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the fix-enums branch September 26, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrussell kenrussell kenrussell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lexaknyazev @kenrussell