Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 692341. |
|
CI Vulkan-ValidationLayers build # 22974 running. |
| "VUID-VkMemoryDedicatedAllocateInfoTensorARM-tensor-09859", | ||
|
|
||
| // VUID-VkDeviceAddress-size-11364 is used instead | ||
| "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-11845" |
There was a problem hiding this comment.
I agree with this, so why I am approving, but this has been a constant issue with the spec,
Before we just approve and forget, I want to grasp where this is going wrong
VUID-vkBuildAccelerationStructuresKHR-pInfos-11820 is the matching version for host device,
also VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-11845 is the same as well
... maybe just make this
// These are caught by VUID-VkDeviceAddress-size-11364 already
// TODO - these should be removed from the spec and they are redundant
"VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-11845",
"VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-11845",There was a problem hiding this comment.
I think both of these are "wrong" because nvidia does not support host builds (VUID-vkCmdBuildAccelerationStructuresIndirectKHR-pInfos-11845) nor indirect builds (vkCmdBuildAccelerationStructuresIndirectKHR) so they don't really make sense
There was a problem hiding this comment.
updating this file
arno-lunarg
force-pushed
the
arno-rt-11845
branch
from
cd436ae to
4d8759c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 692356. |
|
CI Vulkan-ValidationLayers build # 22975 running. |
| // VUID-VkDeviceAddress-size-11364 is used instead | ||
| "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-11845", | ||
| // TODO - these should be removed from the spec | ||
| "VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-11845", |
There was a problem hiding this comment.
- Did you mean
VUID-vkBuildAccelerationStructuresKHR-pInfos-11820? - leave the "reason" why in the comments here (basically we describe it well in layers: Add 11845 #11996 (comment) and it is getting lost from here)
| "VUID-VkMemoryDedicatedAllocateInfo-buffer-01879", | ||
| "VUID-VkMemoryDedicatedAllocateInfoTensorARM-tensor-09859", | ||
|
|
||
| // VUID-VkDeviceAddress-size-11364 is used instead |
There was a problem hiding this comment.
I guess I don't want this to be "we use 11364" and want to make it explicit here that this is a spec issue likely for someone who looks later
|
CI Vulkan-ValidationLayers build # 22975 passed. |
3 participants
No description provided.