gpuav: Fix validation#11986
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 690978. |
|
CI Vulkan-ValidationLayers build # 22959 running. |
|
CI Vulkan-ValidationLayers build # 22959 failed. |
When picking a buffer from a device address range, filter by buffer usage AND buffer size
arno-lunarg
force-pushed
the
arno-gpuav-fix-validation
branch
from
8511c18 to
f7add88
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 691027. |
|
CI Vulkan-ValidationLayers build # 22960 running. |
|
CI Vulkan-ValidationLayers build # 22960 aborted. |
|
CI Vulkan-ValidationLayers build queued with queue ID 691417. |
|
CI Vulkan-ValidationLayers build # 22963 running. |
|
CI Vulkan-ValidationLayers build # 22963 passed. |
layers/state_tracker/state_tracker.h
Outdated
|
|
||
| using BufferFilter = stdext::inplace_function<bool(vvl::Buffer*)>; | ||
| small_vector<vvl::Buffer*, 2> GetBuffersByAddressRange(const VkDeviceAddressRangeKHR& address_range, | ||
| const BufferFilter& filter) const; |
There was a problem hiding this comment.
whey not just pass in a VkBufferUsageFlags2 instead of making this callback?
The main reason is this is implying there is another way to filter the buffers, but it should only be from the usage flag
There was a problem hiding this comment.
I can do that no problem
arno-lunarg
force-pushed
the
arno-gpuav-fix-validation
branch
from
22e663b to
a67dd5c
Compare
|
CI Vulkan-ValidationLayers build queued with queue ID 692180. |
Account for functions added with device address commands
|
CI Vulkan-ValidationLayers build # 22972 running. |
|
CI Vulkan-ValidationLayers build # 22972 passed. |
3 participants
When picking a buffer from a device address range, filter by buffer usage AND buffer size
2nd commit closes #11879