loader: Remove limit on number of ID filters - #2024
Merged
charles-lunarg merged 1 commit intoAug 31, 2026
Merged
Conversation
|
CI Vulkan-Loader build queued with queue ID 97808. |
|
CI Vulkan-Loader build queued with queue ID 97825. |
|
CI Vulkan-Loader build # 3739 running. |
|
CI Vulkan-Loader build # 3739 passed. |
charles-lunarg
approved these changes
Aug 31, 2026
charles-lunarg
left a comment
charles-lunarg
left a comment
Collaborator
There was a problem hiding this comment.
While adding new tests wouldn't be a bad idea, there already are tests for multiple filters, which will exercise the new logic. Plus, we never have to resize the allocation, which has proven to be a common place for errors to creep in.
Contributor
Author
|
Yes, I did not see much point in just adding a test case with arbitrarily large filter list so I thought the existing test coverage should be sufficient. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.