Remove extra double-quote at the end of a comment#2680
Merged
oddhack merged 1 commit intoKhronosGroup:mainfrom Feb 16, 2026
Merged
Remove extra double-quote at the end of a comment#2680oddhack merged 1 commit intoKhronosGroup:mainfrom
oddhack merged 1 commit intoKhronosGroup:mainfrom
Conversation
…reFlagBits2` This was confusing some tokenizing code, where it started parsing double-quoted strings after the end of the "bitpos 13..." comment, generally messing up the parsing of the whole file after that.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I imagine this was just a copy-paste issue with any of the other places that have
VK_EXT_filter_cubicquoted.This was confusing some tokenizing code when hitting
VkFormatFeatureFlagBits2, where it started parsing double-quoted strings after the end of the "bitpos 13..." comment, generally messing up the parsing of the whole file after that.Parsers that don't let double-quoted strings go outside the XML tags would be fine, but I had some internally that didn't, so proposing the change here to be merged if possible.
Thanks! 😄