Skip to content

Commit

Permalink
Fix KHR-Single-GL46.subgroups.* cases failure
Browse files Browse the repository at this point in the history
Drawing a point at a coordinate with integer value will have different
behavior on variant vender's hardware.
So, as a fix, we could initialize the coordinate in the center of the
pixel.

Affects:
KHR-Single-GL46.subgroups.*

Components: OpenGL

VK-GL-CTS issue: https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/4297

Change-Id: I1841306483ebe4b917670743e77f76fc393a3854
  • Loading branch information
feifei14119 authored and piby committed Mar 24, 2023
1 parent bb53f56 commit fb66a8e
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1326,7 +1326,7 @@ tcu::TestStatus glc::subgroups::makeGeometryFrameBufferTest(

{
glw::GLvoid * bufferPtr = vertexBuffer.mapBufferPtr();
std::vector<tcu::Vec4> data (maxWidth, tcu::Vec4(1.0f, 1.0f, 1.0f, 1.0f));
std::vector<tcu::Vec4> data (maxWidth, tcu::Vec4(1.0f, 0.5f, 1.0f, 1.0f));
const float pixelSize = 2.0f / static_cast<float>(maxWidth);
float leftHandPosition = -1.0f;

Expand Down Expand Up @@ -1780,7 +1780,7 @@ tcu::TestStatus glc::subgroups::makeVertexFrameBufferTest(Context& context, Form

{
glw::GLvoid * bufferPtr = vertexBuffer.mapBufferPtr();
std::vector<tcu::Vec4> data (maxWidth, tcu::Vec4(1.0f, 1.0f, 1.0f, 1.0f));
std::vector<tcu::Vec4> data (maxWidth, tcu::Vec4(1.0f, 0.5f, 1.0f, 1.0f));
const float pixelSize = 2.0f / static_cast<float>(maxWidth);
float leftHandPosition = -1.0f;

Expand Down

0 comments on commit fb66a8e

Please sign in to comment.