Skip to content

Commit

Permalink
Handle denorm flush to negative zero in unpackhalf2x16 tests.
Browse files Browse the repository at this point in the history
Whether input fp16 values are flushed to zero is implementation
dependent. However, negative denorm values can be flushed to negative
zero and the logic did not handle that case.

Affects: dEQP-VK.glsl.builtin.function.pack_unpack.unpackhalf2x16*
Component: Vulkan
VK-GL-CTS issue: 1341

Change-Id: I2cd4a68cb5e498cd714a7e55b27ae4bc05ccde2d
  • Loading branch information
jeffbolznv authored and alegal-arm committed Sep 6, 2018
1 parent 0770bab commit 2d586ea
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -856,7 +856,7 @@ class UnpackHalf2x16CaseInstance : public ShaderPackingFunctionTestInstance

if (conversion != CONVERTED && denorm)
{
if (resBits == 0)
if (resBits == 0 || (ref < 0 && resBits == 0x80000000UL))
{
conversion = ZERO_FLUSHED;
return DE_TRUE;
Expand Down

0 comments on commit 2d586ea

Please sign in to comment.