-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic HDRP export support #826
Open
krisrok
wants to merge
12
commits into
KhronosGroup:main
Choose a base branch
from
krisrok:enhancement/hdrp-pbr-basics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting
Thanks for the PR! We'll take a look. Are you planning on adding the remaining changes that are needed to integrate it, e.g. into the animation system? (e.g. different treatment for emissive color animation and so on) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic export support for some of HDRP's standard shaders:
To support the remapping of the mask map values, the channel swap shaders now support min/max values per used channel.
smoothnessMultiplier
is nowsmoothnessRangeMax
andsmoothnessRangeMin
has a default value of 0. Newly introduced min/max ranges also default to 0/1. This way, it should work exactly like before for material exports not using the ranges.There's much to be desired for full support, even in the added functionality: UV sets, multiplicative emission, emission exposure weight come to mind. But for my use cases it works just fine and produces good looking results.