fix several compile issues with Visual Studio toolchains #2219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes several compile issues I am seeing for my version of Visual Studio related to an ambiguous call to
fpclassify
, which is called byisnan
and other similar functions, specifically for thecl_half
type:Some of these issues seem like differences in compiler behavior, but at least one appears to have identified a legitimate bug.
Specifically, this change:
UlpFn
. (test with:test_commonfns degrees radians
)test_relationals relational*
)test_select select_half_ushort select_half_short
)std::enable_if
to disambiguate a function call for spirv_new. (test with:test_spirv_new decorate_saturated*
)If it's helpful, my specific Visual Studio version is:
I also have the Windows Software Development Kit 10.0.19041.685 installed.