Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derived command-buffer Skip() checks #2217

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix derived command-buffer Skip() checks #2217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions test_conformance/extensions/cl_khr_command_buffer/negative_command_buffer_create.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@ struct CreateCommandBufferRepeatedProperties : public BasicCommandBufferTest

bool Skip() override
{
bool skip = true;
if (BasicCommandBufferTest::Skip()) return true;

bool skip = true;
if (simultaneous_use_support)
{
rep_prop = CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR;
Expand Down Expand Up @@ -181,8 +182,9 @@ struct CreateCommandBufferNotSupportedProperties : public BasicCommandBufferTest

bool Skip() override
{
bool skip = true;
if (BasicCommandBufferTest::Skip()) return true;

bool skip = true;
if (!simultaneous_use_support)
{
unsupported_prop = CL_COMMAND_BUFFER_SIMULTANEOUS_USE_KHR;
Expand Down Expand Up @@ -223,6 +225,8 @@ struct CreateCommandBufferQueueWithoutMinProperties

bool Skip() override
{
if (BasicCommandBufferTest::Skip()) return true;

cl_command_queue_properties required_properties;
cl_int error = clGetDeviceInfo(
device, CL_DEVICE_COMMAND_BUFFER_REQUIRED_QUEUE_PROPERTIES_KHR,
Expand Down Expand Up @@ -287,7 +291,7 @@ struct CreateCommandBufferDeviceDoesNotSupportOutOfOderQueue

bool Skip() override
{
BasicCommandBufferTest::Skip();
if (BasicCommandBufferTest::Skip()) return true;

// If device does not support out of order queue or if device supports
// out of order command buffer test should be skipped
Expand Down
4 changes: 4 additions & 0 deletions test_conformance/extensions/cl_khr_command_buffer/negative_command_nd_range_kernel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,8 @@ struct CommandNDRangeKernelNotSupportPrintf : public BasicCommandBufferTest

bool Skip() override
{
if (BasicCommandBufferTest::Skip()) return true;

cl_device_command_buffer_capabilities_khr capabilities;
cl_int error =
clGetDeviceInfo(device, CL_DEVICE_COMMAND_BUFFER_CAPABILITIES_KHR,
Expand Down Expand Up @@ -353,6 +355,8 @@ struct CommandNDRangeKernelWithKernelEnqueueCall : public BasicCommandBufferTest

bool Skip() override
{
if (BasicCommandBufferTest::Skip()) return true;

bool has_device_enqueue = false;
bool cl_version_2_0_or_higher = false;

Expand Down
Loading