-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CMake installation rules #2184
base: main
Are you sure you want to change the base?
Conversation
Add installation rules for all the binary targets. Targets are installed under `<CMAKE_INSTALL_PREFIX>/bin/<CONFIG>` where `<CONFIG>` is `CMAKE_BUILD_TYPE` for single-config generators, e.g. Unix Makefiles and Ninja, or the build configuration for multi-config generators, e.g. Ninja Multi-Config and Visual Studio. This creates the target `install` on Unix and `INSTALL` on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also check if we need to install the Vulkan SPIR-V files? See: #2055
At some point it would be nice to install the OpenCL SPIR-V files in a sensible place also (and ideally, to auto-build them if any of the source spvasm changes), but this is less critical because the path to the OpenCL SPIR-V files can be set using --spirv-binaries-path
.
You're right, yes they do. I note that the CMakeLists.txt for the Vulkan shaders is wrong in two ways:
|
Fixed the way the Vulkan shaders are generated in #2199 as a requirement for having correct installation rules for them. |
#2200 handles the automatic generation of the OpenCL SPIR-V files for |
Add installation rules for all the binary targets.
Targets are installed under
<CMAKE_INSTALL_PREFIX>/bin/<CONFIG>
where<CONFIG>
isCMAKE_BUILD_TYPE
for single-config generators, e.g. Unix Makefiles and Ninja, or the build configuration for multi-config generators, e.g. Ninja Multi-Config and Visual Studio.This creates the target
install
on Unix andINSTALL
on Windows.