Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Implement VK_EXT_rasterization_order_attachment_access #2280

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

csmartdalton
Copy link

Implement VK_EXT_rasterization_order_attachment_access using the "programmable blending" feature available on Apple family GPUs.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@cdavis5e cdavis5e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you make sure that input attachments are numbered correctly in the shader?

@csmartdalton
Copy link
Author

csmartdalton commented Jul 20, 2024

Did you make sure that input attachments are numbered correctly in the shader?

Thank you for taking a look! I was just prototyping under the assumption that shaderConfig.options.mslOptions.use_framebuffer_fetch_subpasses knows how to do everything already. I'm not very familiar with MoltenVK, but willing to do the work to figure it out if this is a change that MoltenVK will be interested in taking once ironed out.

The input attachments are numbered correctly in my own use case (which uses 4), but I haven't otherwise tested it. Since this internally enables framebuffer-fetch supbasses across the board, would the existing test suite be enough to ensure the color attachments are numbered correctly?

Implement VK_EXT_rasterization_order_attachment_access using the
"programmable blending" feature available on Apple family GPUs.
@csmartdalton csmartdalton force-pushed the VK_EXT_rasterization_order_attachment_access branch from 7e21006 to 7de4944 Compare July 20, 2024 15:02
@billhollings billhollings changed the title Implement VK_EXT_rasterization_order_attachment_access WIP: Implement VK_EXT_rasterization_order_attachment_access Jul 26, 2024
Copy link
Contributor

@billhollings billhollings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the initiative and submitting this.

I've marked this as WIP, as it looks like there is work to do to get this working properly for general use cases.

I ran the rasterization_order_attachment_access tests in CTS, and the results are here:

Test run totals:
  Passed:        1/282 (0.4%)
  Failed:        97/282 (34.4%)
  Not supported: 184/282 (65.2%)
  Warnings:      0/282 (0.0%)
  Waived:        0/282 (0.0%)

Details are here: rasterization_order_attachment_access-results.txt.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants