-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
171 add build for ubuntu 2404 #340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-orange
force-pushed
the
171-add-build-for-ubuntu-2404
branch
from
July 30, 2024 15:15
8b27af3
to
341991d
Compare
bruno-at-orange
force-pushed
the
171-add-build-for-ubuntu-2404
branch
from
July 30, 2024 15:51
341991d
to
4ce919a
Compare
popescu-v
reviewed
Jul 31, 2024
popescu-v
requested changes
Jul 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically, LGTM. However, there is a comment that could be addressed IMHO.
popescu-v
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bruno-at-orange
added a commit
that referenced
this pull request
Aug 5, 2024
* Add new docker image for ubuntu 24.04 * Build deb packages for ubuntu 24.04 * test conda packages on ubuntu 24.04 cherry pick from dev #2b49bb0695b2448561c8c8abcf76c338365efbe7
bruno-at-orange
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to test the new deb packages on LearningTest environment (new issue on gitlab)