update khiops-env to display error #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-at-orange
force-pushed
the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
from
f230434
to
df960c2
Compare
popescu-v
reviewed
Jul 31, 2024
popescu-v
reviewed
Jul 31, 2024
|
This should be backported to the Windows env script as well, right? |
popescu-v
requested changes
Jul 31, 2024
bruno-at-orange
force-pushed
the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
2 times, most recently
from
ca31bf4
to
e35ba4a
Compare
popescu-v
reviewed
Aug 2, 2024
popescu-v
reviewed
Aug 2, 2024
bruno-at-orange
force-pushed
the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
from
fd8a7f2
to
cfec496
Compare
popescu-v
reviewed
Aug 5, 2024
bruno-at-orange
changed the title
We will probably add the variables KHIOPS_JAVA_ERROR and KHIOPS_MPI_ERROR in khiops-env.bat. But I prefer to do this on a windows laptop. |
Ok. Hence, this will be done in a separate PR? |
bruno-at-orange
force-pushed
the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
from
a7fe7f7
to
e10f34a
Compare
On Linux, the khiops-env script doesn't print anything in the stdout/err anymore (it is already the case on windows). It only populates environment variables if possible. In case of errors (java or mpi) it populates 2 new variables KHIOPS_MPI_ERROR and KHIOPS_JAVA_ERROR The khiops script use notify-send to diplay errors to users. It implies a new dependency in the khiops package: libnotify on rocky and libnotify-bin on debian. Errors are also logs into /var/log/syslog by using the 'logger' command.
bruno-at-orange
force-pushed
the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
from
e10f34a
to
3d25588
Compare
popescu-v
approved these changes
Aug 8, 2024
bruno-at-orange
deleted the
161-khiops-desktop-doesnt-print-log-in-stderr-in-case-of-java-error
branch
bruno-at-orange
added a commit
that referenced
this pull request
Aug 9, 2024
* Update khiops-env to display error on Linux On Linux, the khiops-env script doesn't print anything in the stdout/err anymore (it is already the case on windows). It only populates environment variables if possible. In case of errors (java or mpi) it populates 2 new variables KHIOPS_MPI_ERROR and KHIOPS_JAVA_ERROR The khiops script use notify-send to diplay errors to users. It implies a new dependency in the khiops package: libnotify on rocky and libnotify-bin on debian. Errors are also logs into /var/log/syslog by using the 'logger' command.
bruno-at-orange
added a commit
that referenced
this pull request
Aug 12, 2024
* Update khiops-env to display error on Linux On Linux, the khiops-env script doesn't print anything in the stdout/err anymore (it is already the case on windows). It only populates environment variables if possible. In case of errors (java or mpi) it populates 2 new variables KHIOPS_MPI_ERROR and KHIOPS_JAVA_ERROR The khiops script use notify-send to diplay errors to users. It implies a new dependency in the khiops package: libnotify on rocky and libnotify-bin on debian. Errors are also logs into /var/log/syslog by using the 'logger' command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The khiops-env script doesn't print anything in the stdout/err anymore. It only populates environment variables if possible. In case of errors (java or mpi) it populates 2 new variables KHIOPS_MPI_ERROR and KHIOPS_JAVA_ERROR
The khiops script uses
notify-sendto diplay errors to users. It implies a new dependency in the khiops package: libnotify on rocky and libnotify-bin on debian. Errors are also logs into /var/log/syslog by using theloggercommand.The modification of the scripts khiops, khiops-coclustering and khiops-env only concern Linux (the scope of the bug #161). The possible update of these scripts for windows will be addressed in another fix (related to #258 )