[DRAFT - DO NOT REVIEW YET] WB-1671: Dropdown: use combobox role in all openers
#2345
+86
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a0cbf60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
NOTE: unchecking the |
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (fe5dd39) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2345"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2345 |
|
Size Change: +19 B (+0.02%) Total Size: 100 kB
ℹ️ View Unchanged
|
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-alywnzgfbr.chromatic.com/ Chromatic results:
|
jandrade
changed the title
combobox role in all openerscombobox role in all openers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Addreses an issue in WB dropdowns where we were using the
buttonrole in theopener, which was causing issues with screen readers. This change updates the
role to
comboboxthat is more appropriate for the dropdown opener.Issue: https://khanacademy.atlassian.net/browse/WB-1671
Test plan:
Navigate to the dropdowns in the Storybook and verify that the role of the
opener is
combobox.More details TBD