Interactive Graph: Extract validation out of scoring #1903
+246
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also union Validation Data type with Scoring Data type
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (77776ee) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1903If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1903 |
|
Size Change: +129 B (+0.01%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
Myranae
commented
Nov 21, 2024
Comment on lines
+284
to
+288
| // The input wasn't correct, so check if it's a blank input (validate) or if | ||
| // it's actually just wrong | ||
| const validationError = validateInteractiveGraph(userInput, scoringData); | ||
| if (validationError) { | ||
| return validationError; |
There was a problem hiding this comment.
The validation function was put here since this is the only place where validation occurs. It seems like it should be okay to check if the user input is blank or if the user hasn't changed the graph yet at the start of scoring, but since that's not what was done and there is a comment specifically about doing this after confirming the input was not correct, I left it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To complete server-side scoring, we are separating out validation logic from scoring logic. This PR separates that logic and associated tests for the Interactive Graph widget.
Issue: LEMS-2595
Test plan: