-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Numeric Input] - Link tooltip content to input field for assistive technologies #1891
base: main
Are you sure you want to change the base?
[Numeric Input] - Link tooltip content to input field for assistive technologies #1891
Conversation
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (d08b48d) and published it to npm. You Example: yarn add @khanacademy/perseus@PR1891 If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR1891 |
Size Change: +218 B (+0.02%) Total Size: 1.29 MB
ℹ️ View Unchanged
|
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
Some notes about weird Voice Over behaviour with my older OS:
OS Browsers Tested
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thank you for implementing this!
Considering the issues with my Voice Over seem to just be that it requires a different access method, I think we're good to go with releasing this. :)
Summary:
Currently, the format options tooltip for the input field is only available to sighted users. People using assistive technologies (like braille or screen readers) are unaware of any formatting options for their answers. This change will add an element adjacent to the input field that includes the content of the tooltip, and an association between the two so that assistive technologies can make use of the format options.
Issue: LEMS-2458
Test plan:
Affected behavior:
Before
After