Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dependabot updates for WB/WS (and group them) #1863

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

jeremywiebe
Copy link
Collaborator

Summary:

Juan and I were discussing keeping Perseus dependnecies up to date with webapp (especially WB and WS). This is a trial run to see if Dependabot will help us. It should open up a new PR any time WB or WS packages are released. And all WB or WS packages that received an update should be updated together in the same Perseus PR.

Issue: "none"

Test plan:

I suspect I'll need to land this and monitor it to test. Github action infra is notoriously difficult to test locally.

@jeremywiebe jeremywiebe self-assigned this Nov 14, 2024
Copy link
Contributor

github-actions bot commented Nov 14, 2024

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (706d132) and published it to npm. You
can install it using the tag PR1863.

Example:

yarn add @khanacademy/perseus@PR1863

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR1863

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Size Change: -93 B (-0.01%)

Total Size: 1.29 MB

Filename Size Change
packages/perseus-editor/dist/es/index.js 699 kB -93 B (-0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 38.9 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 4.27 kB
packages/math-input/dist/es/index.js 77.8 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 1.48 kB
packages/perseus-linter/dist/es/index.js 22.2 kB
packages/perseus/dist/es/index.js 421 kB
packages/perseus/dist/es/strings.js 3.55 kB
packages/pure-markdown/dist/es/index.js 3.66 kB
packages/simple-markdown/dist/es/index.js 12.4 kB

compressed-size-action

@jeremywiebe jeremywiebe requested review from jandrade and a team November 15, 2024 00:33
@jeremywiebe jeremywiebe marked this pull request as ready for review November 15, 2024 00:33
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Nov 15, 2024

Gerald

Required Reviewers
  • @Khan/perseus for changes to .eslintrc.js, .changeset/mighty-rules-talk.md, .github/dependabot.yml, packages/perseus-editor/src/components/widget-editor.tsx, packages/perseus-editor/src/components/__stories__/device-framer.stories.tsx

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

Comment on lines +18 to +24
groups:
wonder-stuff:
patterns:
- "@khanacademy/wonder-stuff-*"
wonder-blocks:
patterns:
- "@khanacademy/wonder-blocks-*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we filter out certain packages? I'm asking as we have a couple of WB deprecated packages that we usually skip when upgrading webapp (wb-color and wb-spacing).

It would be nice if we could skip them programmatically with dependabot so we never see these packages in here, as it would be noisy/counterproductive to have them included.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any usages of wb-color nor wb-spacing in Perseus today. I can exclude them here, but I think I'm going to add an ESLint rule to ensure it doesn't come back. :)

image
    "no-restricted-imports": [
        "error",
        "@khanacademy/wonder-blocks-color",
        "@khanacademy/wonder-blocks-spacing",
    ],

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds perfect, thanks!

…ntally add them back as a dependency at some point (they're deprecated)
Copy link
Member

@jandrade jandrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! also the Lint rule is super useful (I'm going to replicate it in webapp). 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants