fix: eslint #199
fix: eslint #199
Conversation
amitojsingh
commented
Jun 18, 2024
•
amitojsingh
commented
- Fix Eslint errors.
- Refactored the code.
- added footer for next bani.
src/ReaderScreen/utils/index.js
Outdated
| return color || null; | ||
| }; | ||
|
|
||
| export const fontSizeForReader = (SIZE, header, transliteration) => { |
There was a problem hiding this comment.
@amitojsingh veerji,
SIZE is the only parameter in full caps, any specific reason for this?
There was a problem hiding this comment.
Also, there is another variable, in small caps size. Can you use different name for parameter or the variable?
There was a problem hiding this comment.
fixed veer ji.
| [constant.GURMUKHI]: gurmukhiMapping, | ||
| [constant.TRANSLITERATION]: getHeaderColor1(), | ||
| [constant.TRANSLATION]: defaultColor, | ||
| }; |
There was a problem hiding this comment.
What do you think about destructuring the constant object before this? And use GURMUKHI, TRANSLITERATION, and TRANSLATION directly?
There was a problem hiding this comment.
Fixed Veer ji.
| ); | ||
| } | ||
|
|
||
| contentHtml += `</div>`; |
There was a problem hiding this comment.
Can we not use JSX to build this markup, instead of doing it manually from strings?
There was a problem hiding this comment.
nopes veer ji as we tried multiple ways as we discussed earlier and we finalized this way.
