Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even master with dev #134

Open
wants to merge 32 commits into
base: master
Choose a base branch
from
Open

Even master with dev #134

wants to merge 32 commits into from

Conversation

amitojsingh
Copy link
Collaborator

No description provided.

ImgBotApp and others added 4 commits September 29, 2022 12:03
*Total -- 2,058.86kb -> 1,808.99kb (12.14%)

/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/167X167.png -- 9.43kb -> 5.73kb (39.22%)
/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_foreground.png -- 15.39kb -> 12.29kb (20.16%)
/ios/SundarGutka/Images.xcassets/SplashScreen.imageset/_(400 × 800 px).png -- 75.30kb -> 61.66kb (18.12%)
/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_foreground.png -- 10.01kb -> 8.21kb (17.94%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/152.png -- 15.74kb -> 13.15kb (16.46%)
/android/app/src/main/res/mipmap-mdpi/ic_launcher_splash.png -- 77.38kb -> 65.41kb (15.47%)
/android/app/src/main/res/mipmap-xhdpi/ic_launcher_foreground.png -- 5.66kb -> 4.87kb (13.98%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/Icon-60x60.png -- 5.59kb -> 4.86kb (12.97%)
/android/app/src/main/res/mipmap-hdpi/ic_launcher_splash.png -- 114.88kb -> 100.65kb (12.39%)
/ios/SundarGutka/Images.xcassets/SplashScreen.imageset/_(800 × 1600 px).png -- 220.91kb -> 194.88kb (11.78%)
/android/app/src/main/res/mipmap-xhdpi/ic_launcher_splash.png -- 203.80kb -> 179.90kb (11.73%)
/ios/SundarGutka/Images.xcassets/SplashScreen.imageset/(1200 × 2400 px).png -- 401.52kb -> 354.80kb (11.64%)
/ios/SundarGutka/Images.xcassets/khalis-logo.imageset/khalis-logo.png -- 48.59kb -> 43.03kb (11.43%)
/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher_splash.png -- 440.82kb -> 390.47kb (11.42%)
/android/app/src/main/res/mipmap-xxhdpi/ic_launcher_splash.png -- 325.09kb -> 288.58kb (11.23%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/80.png -- 6.41kb -> 5.73kb (10.67%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/76.png -- 5.98kb -> 5.36kb (10.48%)
/android/app/src/main/ic_launcher-playstore.png -- 62.06kb -> 55.72kb (10.21%)
/android/app/src/main/res/mipmap-hdpi/ic_launcher_foreground.png -- 3.65kb -> 3.34kb (8.44%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/58.png -- 3.96kb -> 3.78kb (4.66%)
/android/app/src/main/res/mipmap-mdpi/ic_launcher_foreground.png -- 1.96kb -> 1.91kb (2.79%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/40.png -- 2.37kb -> 2.34kb (1.28%)
/ios/SundarGutka/Images.xcassets/AppIcon.appiconset/40-1.png -- 2.37kb -> 2.34kb (1.28%)

Signed-off-by: ImgBotApp <[email protected]>
Copy link
Contributor

@inderpreetsingh inderpreetsingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitojsingh veerji, it looks like this is going to the production branch. If this is correct, it should also bump up the current application version. If you think it does not require changing the application version then it shouldn't go to production directly instead it should go to a version branch that will be merged to dev and then to master but on the master and dev it should always have alpha and production releases. Let me know what do you think of this veerji 🙏

@amitojsingh amitojsingh marked this pull request as draft October 5, 2022 17:14
@amitojsingh
Copy link
Collaborator Author

@inderpreetsingh Veer ji. The Master branch is currently not matched with the app that was released. so this code is just making the master branch even with the dev. I usually create this PR when I published the app and want the master branch to be the same as the production app.

@amitojsingh amitojsingh marked this pull request as ready for review October 18, 2022 00:45
@theamanjs
Copy link

This one should be merged after #135 is merged. I have reviewed this but not approving it for now so that we don't accidentally merge it.

@theamanjs
Copy link

@amitojsingh veerji, do you want me to review this PR?

@amitojsingh amitojsingh changed the title Even with master Even master with dev Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants