Fix CI Pipeline Issues #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hayden Roszell <[email protected]>
Signed-off-by: Hayden Roszell <[email protected]>
Signed-off-by: Hayden Roszell <[email protected]>
irby
commented
Feb 19, 2025
| @@ -152,5 +152,5 @@ func (s *signer) parseEjbcaError(ctx context.Context, detail string, err error) | |||
|
|
|||
| logger.Error(err, "EJBCA returned an error") | |||
|
|
|||
| return fmt.Errorf(errString) | |||
| return fmt.Errorf("%s", errString) | |||
There was a problem hiding this comment.
Resolves an error generated by golangci-lint.
| @@ -2,11 +2,11 @@ run: | |||
| # timeout for analysis, e.g. 30s, 5m, default is 1m | |||
| timeout: 12m | |||
|
|
|||
| skip-dirs: | |||
| issues: | |||
There was a problem hiding this comment.
Resolves two warnings generated by golangci-lint.
| @@ -30,7 +30,7 @@ jobs: | |||
| - name: Run linters | |||
| uses: golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc # v3.7.0 | |||
| with: | |||
| version: latest | |||
| version: v1.64.5 | |||
There was a problem hiding this comment.
Locking in specific version of this tool should mitigate breaking changes in newer versions of the lint tool.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves as a initial change set for a 2.1 release. Currently, the CI pipeline has some issues that this PR will help resolve. Additionally, it includes some documentation updates that were incorporated into the e2e-tutorial branch but were never merged in.
Fixes to the CI process:
v3of the release workflow instead ofejbca-readme-updates. Fixes an issue when compiling docsource.golangci-linttool.Updates to the CI process:
golangci-linttool to a specific version (1.64.5) instead oflatest. This will ensure newer versions of the tool do not break the CI process.Additional updates:
require.Containsinstead ofrequire.True, the benefit of using this is that if the assertion fails it prints out expected vs received, helpful for troubleshooting breaking changes in the tests.